Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ameba] Support reset-counts command in wifi diagnostics #16824

Merged
merged 1 commit into from
Apr 1, 2022
Merged

[Ameba] Support reset-counts command in wifi diagnostics #16824

merged 1 commit into from
Apr 1, 2022

Conversation

pankore
Copy link
Contributor

@pankore pankore commented Mar 30, 2022 •
edited
Loading

Problem

reset-counts command is failing, returning error 0x01, see #16822.

Change overview

Add an empty function to fix this issue, will be updated again

Testing

Tested with chip-tool
./chip-tool wifinetworkdiagnostics reset-counts 1 0
make sure status returned is 0

@pankore pankore changed the title Support reset-counts command in wifi diagnostics [Ameba] Support reset-counts command in wifi diagnostics Mar 30, 2022
@github-actions
Copy link

github-actions bot commented Mar 30, 2022 •
edited
Loading

PR #16824: Size comparison from 08906fb to 54ef663

Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 08906fb 54ef663 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 606810 606810 0 0.0
.app_xip_area 513580 513580 0 0.0
.bss 75976 75976 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 564358 564358 0 0.0
.app_xip_area 472656 472656 0 0.0
.bss 74480 74480 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 576538 576538 0 0.0
.app_xip_area 475188 475188 0 0.0
.bss 83808 83808 0 0.0
.data 508 508 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 927928 927928 0 0.0
(read/write) 129112 129112 0 0.0
.bss 127112 127112 0 0.0
.data 1996 1996 0 0.0
.text 927920 927920 0 0.0
BRD4161A+rpc (read only) 956920 956920 0 0.0
(read/write) 145064 145064 0 0.0
.bss 142888 142888 0 0.0
.data 2176 2176 0 0.0
.text 956912 956912 0 0.0
window-app BRD4161A (read only) 857412 857412 0 0.0
(read/write) 127072 127072 0 0.0
.bss 125200 125200 0 0.0
.data 1872 1872 0 0.0
.text 857404 857404 0 0.0
esp32 all-clusters-app c3devkit (read only) 968374 968374 0 0.0
(read/write) 1394770 1394770 0 0.0
.dram0.bss 62416 62416 0 0.0
.dram0.data 14204 14204 0 0.0
.flash.rodata 199240 199240 0 0.0
.flash.text 968374 968374 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1024075 1024075 0 0.0
(read/write) 462532 462532 0 0.0
.dram0.bss 67944 67944 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 228728 228728 0 0.0
.flash.text 1018691 1018691 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 705392 705392 0 0.0
.bss 77968 77968 0 0.0
.data 1876 1876 0 0.0
.text 619748 619748 0 0.0
lock k32w061+release (read/write) 704508 704508 0 0.0
.bss 77944 77944 0 0.0
.data 1916 1916 0 0.0
.text 618848 618848 0 0.0
linux all-clusters-app debug (read only) 2536721 2536721 0 0.0
(read/write) 143384 143384 0 0.0
.bss 57408 57408 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 78952 78952 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 216613 216613 0 0.0
.text 2156210 2156210 0 0.0
bridge-app debug+rpc (read only) 1770437 1770437 0 0.0
(read/write) 89552 89552 0 0.0
.bss 44520 44520 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 37968 37968 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 145004 145004 0 0.0
.text 1510005 1510005 0 0.0
chip-tool debug (read only) 10311229 10311229 0 0.0
(read/write) 356456 356456 0 0.0
.bss 22464 22464 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 326808 326808 0 0.0
.dynamic 608 608 0 0.0
.got 4824 4824 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 525877 525877 0 0.0
.text 8999013 8999013 0 0.0
chip-tool-ipv6only arm64 (read only) 9923868 9923868 0 0.0
(read/write) 475441 475441 0 0.0
.bss 40753 40753 0 0.0
.data 1144 1144 0 0.0
.data.rel.ro 373536 373536 0 0.0
.dynamic 560 560 0 0.0
.got 56200 56200 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 501012 501012 0 0.0
.text 8365268 8365268 0 0.0
door-lock-app debug (read only) 2023065 2023065 0 0.0
(read/write) 116928 116928 0 0.0
.bss 47648 47648 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62872 62872 0 0.0
.dynamic 592 592 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 181596 181596 0 0.0
.text 1691586 1691586 0 0.0
lighting-app debug+rpc (read only) 2199433 2199433 0 0.0
(read/write) 123888 123888 0 0.0
.bss 48928 48928 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 67944 67944 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 175452 175452 0 0.0
.text 1864738 1864738 0 0.0
ota-provider-app debug (read only) 1963457 1963457 0 0.0
(read/write) 112720 112720 0 0.0
.bss 47584 47584 0 0.0
.data 1256 1256 0 0.0
.data.rel.ro 58216 58216 0 0.0
.dynamic 608 608 0 0.0
.got 4384 4384 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 167371 167371 0 0.0
.text 1644146 1644146 0 0.0
ota-requestor-app debug (read only) 1990697 1990697 0 0.0
(read/write) 115944 115944 0 0.0
.bss 48512 48512 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 60472 60472 0 0.0
.dynamic 592 592 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 163556 163556 0 0.0
.text 1674194 1674194 0 0.0
shell debug (read only) 2451489 2451489 0 0.0
(read/write) 147400 147400 0 0.0
.bss 67304 67304 0 0.0
.data 800 800 0 0.0
.data.rel.ro 73592 73592 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 210066 210066 0 0.0
.text 2084402 2084402 0 0.0
thermostat-no-ble arm64 (read only) 2281172 2281172 0 0.0
(read/write) 148337 148337 0 0.0
.bss 62817 62817 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 76952 76952 0 0.0
.dynamic 560 560 0 0.0
.got 4512 4512 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 140036 140036 0 0.0
.text 1917744 1917744 0 0.0
tv-app debug (read only) 2699113 2699113 0 0.0
(read/write) 247552 247552 0 0.0
.bss 164288 164288 0 0.0
.data 3136 3136 0 0.0
.data.rel.ro 74064 74064 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 206443 206443 0 0.0
.text 2317970 2317970 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2357388 2357388 0 0.0
.bss 185020 185020 0 0.0
.data 5760 5760 0 0.0
.text 1319988 1319988 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1144823 1144823 0 0.0
bss 143052 143052 0 0.0
rodata 142432 142432 0 0.0
text 784496 784496 0 0.0
p6 all-clusters-app default (read/write) 2499976 2499976 0 0.0
.bss 118440 118440 0 0.0
.data 2640 2640 0 0.0
.text 1458240 1458240 0 0.0
light-app default (read/write) 2402144 2402144 0 0.0
.bss 111912 111912 0 0.0
.data 2496 2496 0 0.0
.text 1360408 1360408 0 0.0
lock-app default (read/write) 2365760 2365760 0 0.0
.bss 111656 111656 0 0.0
.data 2456 2456 0 0.0
.text 1324024 1324024 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 789148 789148 0 0.0
bss 70268 70268 0 0.0
noinit 40416 40416 0 0.0
text 559380 559380 0 0.0

woody-apple
woody-apple approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@woody-apple woody-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast tracking platform changes.

@woody-apple woody-apple merged commit 2c1d07b into project-chip:master Apr 1, 2022
@pankore pankore deleted the diagnostic_update branch April 5, 2022 04:55
chencheung pushed a commit to chencheung/connectedhomeip that referenced this pull request Apr 6, 2022
@pankore @chencheung
Support reset-counts command in wifi diagnostics (project-chip#16824)
7d53cf6
chencheung pushed a commit to chencheung/connectedhomeip that referenced this pull request Apr 6, 2022
@pankore @chencheung
Support reset-counts command in wifi diagnostics (project-chip#16824)
9ef5b17
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@pankore @andrei-menzopol
Support reset-counts command in wifi diagnostics (project-chip#16824)
f586444
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
fast track platform review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pankore @woody-apple @bzbarsky-apple